Skip to content

Update events #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Update events #932

wants to merge 10 commits into from

Conversation

@delvedor
Copy link
Member

@delvedor delvedor commented Aug 6, 2019 •
edited
Loading

This pr adds the prepare-request event, which comes very handy if someone needs to track when a request has started (the request event is emitted after the serialization and building the headers).

prepare-request emits an object with the following keys:

  • meta: all the metadata about the request
  • params: the parameters the user has passed to the API
  • options: the custom options for the request

In addition, if the serialization fails, the request event will be emitted with an error.

The event flow now is:

  • prepare-request
  • request
  • sniff (not guaranteed)
  • resurrect (not guaranteed)
  • response

Related: #834 elastic/apm-agent-nodejs#968

@delvedor delvedor requested a review from watson August 6, 2019 16:30
@delvedor delvedor marked this pull request as ready for review August 7, 2019 10:34
@delvedor delvedor mentioned this pull request Aug 8, 2019
Closed
4 tasks
@delvedor delvedor removed v5.x labels Aug 8, 2019
watson
watson approved these changes Aug 9, 2019
View reviewed changes
Copy link

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stale
Copy link

stale bot commented Aug 24, 2019

We understand that this might be important for you, but this issue has been automatically marked as stale because it has not had recent activity either from our end or yours.
It will be closed if no further activity occurs, please write a comment if you would like to keep this going.

Note: in the past months we have built a new client, that has just landed in master. If you want to open an issue or a pr for the legacy client, you should do that in https://github.com/elastic/elasticsearch-js-legacy

@stale stale bot added the stale label Aug 24, 2019
@stale stale bot closed this Aug 31, 2019
@delvedor delvedor reopened this Sep 10, 2019
@stale stale bot removed the stale label Sep 10, 2019
@stale
Copy link

stale bot commented Oct 17, 2019

We understand that this might be important for you, but this issue has been automatically marked as stale because it has not had recent activity either from our end or yours.
It will be closed if no further activity occurs, please write a comment if you would like to keep this going.

Note: in the past months we have built a new client, that has just landed in master. If you want to open an issue or a pr for the legacy client, you should do that in https://github.com/elastic/elasticsearch-js-legacy

@stale stale bot added the stale label Oct 17, 2019
@stale stale bot closed this Oct 24, 2019
@delvedor delvedor deleted the update-events branch March 23, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@watson watson watson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@delvedor @watson